putting all function definitions in the.variable and type naming style ( Coord vs move_state),.capitalization of file names ( board.h vs Presenter.h),.Consistency helps other people read, understand, and trust your code.For all of these reasons, I'd suggest that only the Board should know about positions, and to eliminate the Coord member from each Piece and that any move validity checking should pass not only the proposed Coord but the Board and current Coord as well. Also, for some moves, such as castling, or capturing a pawn en passant, two pieces are involved and not only their positions but something about their history must be known. This information more properly belongs to the Board class, so I would recommend passing a Board reference to the Piece to allow it to check for move validity. A bishop, for instance, cannot jump over other pieces, so determining a valid move will require examining all of the points between the current and proposed position as well. What will each piece need to determine whether a move is valid? The current interface only passes the proposed new coordinates to change_position. If we think about a future version of this program that actually has rooks, knights, etc. Is it board.h or Board.h? Presenter.h or presenter.h? It's important to be consistent because consistency aids reader comprehension. The compiler will create a destructor by default which is essentially identical to what you've got for the Presenter class, so you can simply omit both the declaration and implementation from your code. Let the compiler create default destructor There is no useful thing that a Presenter can do with a Board pointer that is nullptr, so I'd strongly recommend using a std::shared_ptr instead or by having the Board object be a member of the Presenter class. Reduce the use of raw pointers where practical

If (oldX > 8 || oldY > 8 || newX > 8 || newY > 8)įor (int i = 0 i 5) pieces = new Piece( making sure the numbers are within the board Std::cout (0,5)' > oldX > oldY > newX > newY This array represents the positions of the pieces, but the piece class also has a variable to store its position (used to check the validity of the move sense each piece has a different move capabilities). For example, in the board class it has a 2D array of pieces.

Chess layout